Skip to content

feat: add expression array_size #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: add expression array_size #1122

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
22617c1
first version of array_size
Groennbeck Nov 26, 2024
c33d711
fix lint issues
Groennbeck Nov 26, 2024
ae100e1
fix code pointers in PR-comment
Groennbeck Nov 26, 2024
f2512ca
exactly one child, and line break between functions
Groennbeck Nov 26, 2024
afc926d
Merge branch 'main' of github.com:Groennbeck/datafusion-comet into ar…
Groennbeck Feb 10, 2025
b078747
Merge branch 'main' of github.com:Groennbeck/datafusion-comet into ar…
Groennbeck Feb 10, 2025
6404a83
module use
Groennbeck Feb 10, 2025
938de8d
error in scala case
Groennbeck Feb 10, 2025
1a1efb1
spotless apply
Groennbeck Feb 10, 2025
15ba494
match legazy of size null
Groennbeck Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
match legazy of size null
  • Loading branch information
@Groennbeck
Groennbeck committed Feb 10, 2025
commit 15ba4943f42c2ea8f2a623348d297839e3ac3ffb
2 changes: 1 addition & 1 deletion spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2333,7 +2333,7 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim
expr.children(2))
None
}
case Size(child, _) if child.dataType.isInstanceOf[ArrayType] =>
case Size(child, false) if child.dataType.isInstanceOf[ArrayType] =>
val srcExprProto = exprToProto(child, inputs, binding)
val arraySizeBuilder = ExprOuterClass.ArraySize
.newBuilder()
Expand Down