-
Notifications
You must be signed in to change notification settings - Fork 201
feat: Set/cancel with job tag and make max broadcast table size configurable #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
============================================
+ Coverage 56.12% 58.72% +2.59%
- Complexity 976 1083 +107
============================================
Files 119 126 +7
Lines 11743 12565 +822
Branches 2251 2361 +110
============================================
+ Hits 6591 7379 +788
- Misses 4012 4014 +2
- Partials 1140 1172 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
} | ||
|
||
def maxBroadcastTableBytes(conf: SQLConf): Long = { | ||
JavaUtils.byteStringAsBytes(conf.getConfString(SPARK_MAX_BROADCAST_TABLE_SIZE, "8GB")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conf is only available since Spark 4.1, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conf is only available since Spark 4.1, right?
Yes, but we can port it to any version. For the native engine, we may configure a smaller heap memory, which makes broadcast more likely to cause OOM. I think we can use this configuration to limit the maximum bytes of broadcast.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see it being back-ported to the 3.x branch, but as long as this builds against older releases and doesn't throw an exception that the conf could not be found, we are ok.
Which issue does this PR close?
Closes #1692, #1691.
Rationale for this change
Improve CometBroadcastExchangeExec:
What changes are included in this PR?
How are these changes tested?
added maxBroadcastTableSize test