-
Notifications
You must be signed in to change notification settings - Fork 201
Feat: support bit_get function #1713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this PR supposed to replace the #1602 PR ?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1713 +/- ##
============================================
+ Coverage 56.12% 58.80% +2.68%
- Complexity 976 1142 +166
============================================
Files 119 130 +11
Lines 11743 12626 +883
Branches 2251 2359 +108
============================================
+ Hits 6591 7425 +834
- Misses 4012 4029 +17
- Partials 1140 1172 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Same comment as in #1602 (#1602 (comment)) |
Which issue does this PR close?
Related to Epic: #240
bit_get: SELECT bit_get(0) => 0
DataFusionComet bit_get has same behavior with Spark 's bit_get function
Spark: https://spark.apache.org/docs/latest/api/sql/index.html#bit_get
Closes #.
Rationale for this change
Defined under Epic: #240
What changes are included in this PR?
bitwise_get.rs: impl for bit_get function
QueryPlanSerde.scala: bit_get pattern matching case has been added,
bitwise.scala: The bit_get function is the last function of the bitwise expressions type from the epic: #240. I moved them into a separate file, following the same approach as with the array functions.
CometBitwiseExpressionSuite.scala: A new UT has been added for bit_get function.
How are these changes tested?
A new UT has been added.