Skip to content

[wip] feat: Add framework for supporting multiple telemetry providers #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented May 8, 2025

Which issue does this PR close?

Part of #1718

Rationale for this change

Experimenting with supporting OpenTelemetry as an option.

What changes are included in this PR?

How are these changes tested?

With otel enabled, I see these warning in the executor logs:

25/05/08 11:42:59 WARN GrpcExporter: Failed to export spans. Server responded with gRPC status code 2. Error message: Failed to connect to localhost/127.0.0.1:4317
25/05/08 11:43:01 WARN GrpcExporter: Failed to export metrics. Server responded with gRPC status code 2. Error message: Failed to connect to localhost/127.0.0.1:4317

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2025

Codecov Report

Attention: Patch coverage is 53.44828% with 27 lines in your changes missing coverage. Please review.

Project coverage is 58.63%. Comparing base (f09f8af) to head (ce41884).
Report is 181 commits behind head on main.

Files with missing lines Patch % Lines
...apache/comet/telemetry/OpenTelemetryProvider.scala 0.00% 17 Missing ⚠️
...ache/comet/telemetry/ChromeTelemetryProvider.scala 0.00% 6 Missing ⚠️
...org/apache/comet/telemetry/TelemetryProvider.scala 80.00% 0 Missing and 2 partials ⚠️
...ain/scala/org/apache/comet/CometExecIterator.scala 90.00% 1 Missing ⚠️
...apache/comet/telemetry/NoopTelemetryProvider.scala 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1722      +/-   ##
============================================
+ Coverage     56.12%   58.63%   +2.51%     
- Complexity      976     1142     +166     
============================================
  Files           119      133      +14     
  Lines         11743    12683     +940     
  Branches       2251     2368     +117     
============================================
+ Hits           6591     7437     +846     
- Misses         4012     4067      +55     
- Partials       1140     1179      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants