Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell script to collect Benchmarks #15144

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

logan-keede
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

Here is a suggestion on how to proceed with this project:

  1. Create the converter from bench json --> line protocol (e.g. Export benchmark information as line protocol #6107)
  2. Write a script that runs the bench.sh script to gather the clickbench performance numbers over the last 5 releases:
git checkout 40.0.0
./bench.sh run clickbench_partitioned
git checkout 41.0.0
./bench.sh run clickbench_partitioned
...
git checkout 45.0.0
./bench.sh run clickbench_partitioned

And then load/plot that data using Grafana.

Originally posted by @alamb in #5504

What changes are included in this PR?

Just a simple script to collect benchmarks for last 5 releases

Are these changes tested?

Yes, by running the script on my laptop.
using sh collect_bench.sh tpch.

Are there any user-facing changes?

Nope.

@logan-keede
Copy link
Contributor Author

One problem that I sometimes encounter is that cargo decides to use arrow-arith v53.4.0 for particular releases which ends up giving compilation error.
I’m not sure why this happens. Sometimes, for the same script and same release, cargo decides to use some other version of arrow-arith and everything works fine.
If anyone knows a workaround, please let me know.

@alamb
Copy link
Contributor

alamb commented Mar 12, 2025

Sorry @logan-keede -- I am very excited to try this one out, but I ran otu of time today

@logan-keede
Copy link
Contributor Author

Sorry @logan-keede -- I am very excited to try this one out, but I ran otu of time today

No problem at all! I look forward to your feedback whenever you have the time.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @logan-keede that is pretty neat, appreciate if you document the script and its usage in benchmarks/README.md

@logan-keede
Copy link
Contributor Author

Just noticed that benchmarks/README.md is not included in prettier CI check, is that intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants