fix: compound_field_access doesn't identifier qualifier. #15153
+134
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adragomir
added a commit
to hstack/arrow-datafusion
that referenced
this pull request
Mar 13, 2025
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
In sql_compound_field_access_to_expr, datafusion doesn't check whether prefix can be merged into qualifier,
but in sql_compound_identifier_to_expr, it does.
What changes are included in this PR?
update sql_compound_field_access_to_expr to identify if a compound expression (like
a.b.c) should be treated as a column reference with a qualifier (liketable.column)Are these changes tested?
Unit test
Are there any user-facing changes?
No