Fix datafusion proto crate json feature
#15172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix datafusion proto crate json feature
alamb
reviewed
Mar 12, 2025
There was a problem hiding this comment.
Thank you @Owen-CH-Leung 🙏
Can you please merge up from main now that this PR is merged
- Split out
datafusion-substraitanddatafusion-protoCI feature checks, increase coverage #15156
And update the ci test to ensure we don't break it again?
(per @timsaucer 's comments #15157 (comment))
11 tasks
I took the liberty of pushing a commit that did this: Thanks again @Owen-CH-Leung |
alamb
approved these changes
Mar 13, 2025
github-actions
bot
added
the
development-process
alamb
changed the title
json feature
Just saw your msg. Thanks for helping to rebase :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15157
This PR fixes the json feature of the datafusion proto crate which is currently broken as main.