Minor: split EXPLAIN and ANALYZE planning into different functions #15188
+167
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
waynexia
approved these changes
Mar 12, 2025
|
Thanks for the review @waynexia ! Since this is a small refactoring I will merge this one in so I can get the real PR ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers
I recommend look at the diff while ignoring whitespace (e.g. this link) as I think the change is much clearer (and smaller)
Which issue does this PR close?
EXPLAINformats via SQL #15021EXPLAIN ... FORMAT <indent | tree | json | graphviz > ...#15166Rationale for this change
I would like to make it easier to review #15166 so I pulled out a mechanical change into a new PR
What changes are included in this PR?
explainandanalyzeinto two functions (with much less indent!)Are these changes tested?
By existing tests
Are there any user-facing changes?