Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Move catalog_common out of core #15193

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

logan-keede
Copy link
Contributor

@logan-keede logan-keede commented Mar 12, 2025

Which issue does this PR close?

Rationale for this change

We can move catalog out of core now.
Deprecated Functionality Removed because DataFusion 45.0.0 is released.

What changes are included in this PR?

Are these changes tested?

Yes, as much as I could in my PC.

Are there any user-facing changes?

There should not be.
This is pretty much complete. I will just add re-exports tomorrow and do a self-review before opening for review.

@github-actions github-actions bot added core Core DataFusion crate catalog Related to the catalog crate labels Mar 12, 2025
@logan-keede logan-keede marked this pull request as ready for review March 13, 2025 18:03
Copy link
Member

@Weijun-H Weijun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @logan-keede. This PR seems to only relocate code without changing any internal logic. Wait for feedback from others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
catalog Related to the catalog crate core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Epic] Extract catalog functionality from the core to make it more modular
2 participants