Remove inline table scan analyzer rule #15201
Open
+53
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
reviewed
Mar 13, 2025
There was a problem hiding this comment.
Thanks @jayzhan211
I have a suggestion -- let me know what you think
I would also like to run planning benchmarks on this PR -- will do later
datafusion/sql/src/select.rs
Outdated
| @@ -550,7 +550,29 @@ impl<S: ContextProvider> SqlToRel<'_, S> { | |||
| 0 => Ok(LogicalPlanBuilder::empty(true).build()?), | |||
| 1 => { | |||
| let input = from.remove(0); | |||
| self.plan_table_with_joins(input, planner_context) | |||
| let table = self.plan_table_with_joins(input, planner_context)?; | |||
There was a problem hiding this comment.
This will have the effect of only inlining table scans for SQL
Perhaps we could move the code into LogicalPlanBuilder so it also applies to dataframes?
There was a problem hiding this comment.
both dataframe and sql works well now
github-actions
bot
added
logical-expr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Analyzerwithin LogicalPlan building stage #14618Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?