Improve feature flag CI coverage datafusion and datafusion-functions
#15203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
development-process
alamb
commented
Mar 13, 2025
| @@ -82,6 +82,8 @@ jobs: | |||
| uses: ./.github/actions/setup-builder | |||
| with: | |||
| rust-version: stable | |||
| - name: Check datafusion-common (default features) | |||
There was a problem hiding this comment.
there was no check for default set of features (even the tests run with avro, etc) so I added that
alamb
changed the title
datafusion and datafusion-functionsdatafusion and datafusion-functions, remove core_expressions feature
alamb
changed the title
datafusion and datafusion-functions, remove core_expressions featuredatafusion and datafusion-functions
alamb
commented
Mar 13, 2025
| - name: Check datafusion-substrait (no-default-features) | ||
| run: cargo check --profile ci --all-targets --no-default-features -p datafusion-substrait | ||
| # | ||
| # Note: Only check libraries (not --all-targets) to cover end user APIs |
There was a problem hiding this comment.
The idea is to test only --all-targets for the default features (what a developer would likely run), otherwise the CI will just verify that a user of the crate can compile things rather than check all tests and benches too
|
@xudong963 I wonder if you have some time to review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion-substraitanddatafusion-protoCI feature checks, increase coverage #15156Rationale for this change
I reviewed the CI coverage for datafusion's (many!) feature flag and it is haphazard -- for example it was not clear where to add a test for #15124
What changes are included in this PR?
datafusionanddatafusion-functionscrateAre these changes tested?
Are there any user-facing changes?