Implement tree explain for CsvSink
#15204
Conversation
| ---- | ||
| physical_plan | ||
| 01)┌───────────────────────────┐ | ||
| 02)│ DataSinkExec │ |
There was a problem hiding this comment.
It is interesting that the format is not shown in this plan 🤔
There was a problem hiding this comment.
It's triggered by DataSinkExec:
DisplayFormatType::TreeRender => self.sink().fmt_as(t, f)
CsvSink is only a part of the DataSinkExec format.
A more reasonable output format might be:
DataSinkExec
---------------
sink=csv
filegroup...
There was a problem hiding this comment.
I agree -- can you make a follow on PR for this?
There was a problem hiding this comment.
I created a new PR #15206, and I found that the actual type of the sink can be determined from the file extension.
| @@ -666,8 +666,10 @@ impl DisplayAs for CsvSink { | |||
| write!(f, ")") | |||
| } | |||
| DisplayFormatType::TreeRender => { | |||
| // TODO: collect info | |||
| write!(f, "") | |||
| if !self.config.file_groups.is_empty() { | |||
There was a problem hiding this comment.
I debugged a bit more and it seems the issue is that the actual filename target is in self.config.table_path rather than self.config_file_groups
However, this way is consisent with the other data sinks
@irenjj is there any chance you can make a ticket / PR to fix this?
There was a problem hiding this comment.
I will fix this issue together in #15112.
|
This PR also has new test coverage so I am merging it in and we can improve the display in a future follow on |
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?