Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [opt](nereids) set column stats unkown by default when derive Not expressoin #48864 #49023

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #48864

…ressoin (#48864)

### What problem does this PR solve?
The stats derivation of the Not expression needs to consider the type of
the Not child expression. Therefore, specific implementations need to be
added for each type of child expression, and thus the check for the
child expression type is added. An exception is thrown when the check
fails. Although this can detect the omitted child types as early as
possible, it will cause problems in customer scenarios. This PR will
remove this type check.
@github-actions github-actions bot requested a review from dataroaring as a code owner March 13, 2025 06:54
@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 13, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40118 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cd85cf55ccf35045e1fdf8de808d1868f55dc042, data reload: false

------ Round 1 ----------------------------------
q1	17631	6884	6639	6639
q2	2063	173	165	165
q3	10811	1068	1195	1068
q4	10347	823	727	727
q5	7711	2930	2850	2850
q6	221	136	138	136
q7	983	624	614	614
q8	9385	1966	2096	1966
q9	6661	6446	6377	6377
q10	7158	2259	2308	2259
q11	469	263	261	261
q12	409	211	210	210
q13	17786	2986	3029	2986
q14	229	209	205	205
q15	513	462	472	462
q16	667	614	592	592
q17	990	560	612	560
q18	7406	6766	6669	6669
q19	1397	1047	1020	1020
q20	485	206	194	194
q21	4020	3166	3364	3166
q22	1113	993	992	992
Total cold run time: 108455 ms
Total hot run time: 40118 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6702	6584	6603	6584
q2	330	234	228	228
q3	2909	2791	2951	2791
q4	2047	1850	1805	1805
q5	5811	5756	5745	5745
q6	211	129	128	128
q7	2268	1818	1864	1818
q8	3388	3602	3532	3532
q9	8830	8897	8936	8897
q10	3588	3503	3539	3503
q11	594	496	500	496
q12	838	599	601	599
q13	9436	3193	3160	3160
q14	310	262	282	262
q15	532	462	469	462
q16	682	657	677	657
q17	1877	1631	1620	1620
q18	8426	7810	7683	7683
q19	1750	1594	1598	1594
q20	2059	1846	1881	1846
q21	5509	5517	5464	5464
q22	1145	1021	1039	1021
Total cold run time: 69242 ms
Total hot run time: 59895 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197328 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cd85cf55ccf35045e1fdf8de808d1868f55dc042, data reload: false

query1	1327	917	907	907
query2	6262	2200	2126	2126
query3	10827	4360	4168	4168
query4	61112	33876	23648	23648
query5	5178	447	446	446
query6	315	166	170	166
query7	4907	324	317	317
query8	285	226	226	226
query9	6526	2661	2646	2646
query10	418	264	255	255
query11	15761	15262	15475	15262
query12	160	109	104	104
query13	1074	464	459	459
query14	11099	7298	7240	7240
query15	194	191	180	180
query16	7117	516	497	497
query17	1188	592	586	586
query18	1817	316	337	316
query19	208	168	156	156
query20	122	110	115	110
query21	212	116	104	104
query22	4892	4484	4792	4484
query23	34692	33761	33913	33761
query24	6278	2914	2904	2904
query25	544	441	425	425
query26	659	174	173	173
query27	1860	367	369	367
query28	4176	2550	2455	2455
query29	711	487	453	453
query30	241	164	167	164
query31	983	825	835	825
query32	63	53	56	53
query33	437	279	289	279
query34	928	508	522	508
query35	857	728	723	723
query36	1074	949	975	949
query37	116	62	66	62
query38	4101	3960	4028	3960
query39	1516	1461	1460	1460
query40	203	99	98	98
query41	49	49	48	48
query42	110	102	100	100
query43	551	507	506	506
query44	1158	829	845	829
query45	188	174	179	174
query46	1183	733	757	733
query47	2021	1916	1924	1916
query48	482	389	402	389
query49	712	388	408	388
query50	827	423	414	414
query51	7389	7349	7280	7280
query52	104	92	94	92
query53	258	191	191	191
query54	574	474	490	474
query55	80	77	80	77
query56	267	243	250	243
query57	1300	1159	1166	1159
query58	228	216	220	216
query59	3284	3083	2848	2848
query60	278	263	253	253
query61	110	108	109	108
query62	749	678	666	666
query63	213	184	185	184
query64	1361	695	651	651
query65	3258	3182	3176	3176
query66	714	297	312	297
query67	15992	15844	15498	15498
query68	3603	603	585	585
query69	426	270	261	261
query70	1201	1107	1164	1107
query71	352	262	255	255
query72	6304	3933	3936	3933
query73	745	354	356	354
query74	10386	8930	9191	8930
query75	3321	2642	2654	2642
query76	1725	1037	1111	1037
query77	487	272	266	266
query78	10701	9617	9686	9617
query79	1304	600	602	600
query80	824	443	418	418
query81	518	241	236	236
query82	1262	88	88	88
query83	158	138	142	138
query84	284	80	81	80
query85	860	307	288	288
query86	326	288	291	288
query87	4504	4259	4357	4259
query88	3725	2392	2362	2362
query89	406	299	286	286
query90	1985	185	184	184
query91	187	149	149	149
query92	59	49	50	49
query93	1772	560	559	559
query94	716	291	268	268
query95	354	253	249	249
query96	614	284	283	283
query97	3294	3204	3163	3163
query98	210	202	199	199
query99	1579	1263	1276	1263
Total cold run time: 308072 ms
Total hot run time: 197328 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cd85cf55ccf35045e1fdf8de808d1868f55dc042, data reload: false

query1	0.03	0.03	0.02
query2	0.06	0.04	0.03
query3	0.23	0.07	0.07
query4	1.63	0.11	0.11
query5	0.54	0.52	0.52
query6	1.17	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.55	0.50	0.49
query10	0.55	0.54	0.55
query11	0.14	0.10	0.10
query12	0.15	0.11	0.11
query13	0.61	0.60	0.60
query14	2.77	2.74	2.72
query15	0.88	0.82	0.82
query16	0.40	0.38	0.39
query17	1.06	1.08	1.05
query18	0.24	0.22	0.22
query19	1.82	1.90	2.01
query20	0.01	0.01	0.02
query21	15.35	0.58	0.59
query22	2.27	2.51	2.02
query23	17.17	0.92	0.83
query24	3.24	0.61	2.46
query25	0.31	0.23	0.09
query26	0.46	0.14	0.13
query27	0.04	0.05	0.04
query28	9.43	0.48	0.48
query29	12.66	3.21	3.20
query30	0.26	0.06	0.06
query31	2.87	0.39	0.38
query32	3.26	0.46	0.46
query33	3.01	3.04	3.02
query34	16.94	4.45	4.46
query35	4.53	4.54	4.46
query36	0.67	0.47	0.50
query37	0.09	0.07	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.14	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.02
Total cold run time: 105.85 s
Total hot run time: 32.04 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants