Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](template) Fix potential unexpected implicit convert in function call #49031

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Mar 13, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #45265

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@zclllyybb
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 32649 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit aab3f5a58a0a49db3fe7a973b0bf0c70601446d7, data reload: false

------ Round 1 ----------------------------------
q1	17647	5189	5013	5013
q2	2031	302	166	166
q3	10403	1309	736	736
q4	10225	999	539	539
q5	7564	2429	2365	2365
q6	189	165	132	132
q7	931	754	607	607
q8	9321	1299	1118	1118
q9	5193	4915	4974	4915
q10	6841	2331	1910	1910
q11	478	277	259	259
q12	347	353	216	216
q13	17780	3677	3029	3029
q14	231	231	210	210
q15	537	477	486	477
q16	622	637	588	588
q17	569	865	349	349
q18	6848	6578	6372	6372
q19	1211	962	548	548
q20	312	360	199	199
q21	2939	2136	1900	1900
q22	1039	1022	1001	1001
Total cold run time: 103258 ms
Total hot run time: 32649 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5126	5106	5088	5088
q2	238	325	222	222
q3	2176	2681	2320	2320
q4	1470	1832	1370	1370
q5	4237	4167	4158	4158
q6	207	171	123	123
q7	1939	1934	1759	1759
q8	2606	2784	2581	2581
q9	7226	7166	7246	7166
q10	2996	3190	2765	2765
q11	587	515	498	498
q12	704	791	613	613
q13	3513	3911	3238	3238
q14	277	284	267	267
q15	523	477	468	468
q16	633	702	633	633
q17	1135	1609	1350	1350
q18	7781	7783	7530	7530
q19	820	746	834	746
q20	1990	2004	1897	1897
q21	5448	4973	4708	4708
q22	1070	1049	1006	1006
Total cold run time: 52702 ms
Total hot run time: 50506 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186519 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit aab3f5a58a0a49db3fe7a973b0bf0c70601446d7, data reload: false

query1	1009	392	384	384
query2	6527	1931	1922	1922
query3	6803	215	217	215
query4	26737	23640	23640	23640
query5	5543	685	481	481
query6	309	194	186	186
query7	4613	498	306	306
query8	297	239	238	238
query9	8668	2627	2616	2616
query10	517	310	251	251
query11	15753	15176	15181	15176
query12	160	109	106	106
query13	1669	539	394	394
query14	10508	6260	6495	6260
query15	211	180	169	169
query16	7664	617	429	429
query17	1552	704	548	548
query18	1985	402	299	299
query19	219	181	148	148
query20	118	115	114	114
query21	213	124	111	111
query22	4511	4595	4262	4262
query23	33864	33052	33085	33052
query24	7084	2378	2362	2362
query25	492	442	385	385
query26	1224	271	152	152
query27	2322	473	325	325
query28	4204	2403	2391	2391
query29	677	558	438	438
query30	281	217	200	200
query31	941	855	738	738
query32	69	64	65	64
query33	560	357	307	307
query34	786	841	497	497
query35	806	822	730	730
query36	949	993	917	917
query37	115	99	74	74
query38	4127	4392	4177	4177
query39	1465	1417	1380	1380
query40	211	115	104	104
query41	57	53	53	53
query42	123	104	101	101
query43	504	500	479	479
query44	1278	780	768	768
query45	176	171	167	167
query46	839	1029	620	620
query47	1807	1797	1753	1753
query48	377	415	295	295
query49	807	530	417	417
query50	672	720	428	428
query51	4202	4235	4188	4188
query52	102	104	93	93
query53	231	258	188	188
query54	489	494	416	416
query55	82	78	85	78
query56	273	269	267	267
query57	1113	1156	1068	1068
query58	244	237	236	236
query59	2692	2742	2704	2704
query60	276	279	279	279
query61	147	120	127	120
query62	795	742	665	665
query63	223	185	187	185
query64	4164	1057	674	674
query65	4427	4363	4352	4352
query66	1009	407	322	322
query67	15713	15546	15392	15392
query68	7587	869	490	490
query69	491	307	259	259
query70	1228	1179	1121	1121
query71	461	310	267	267
query72	5512	3562	3843	3562
query73	717	750	352	352
query74	9272	9202	8723	8723
query75	3345	3181	2732	2732
query76	3360	1212	822	822
query77	565	368	283	283
query78	10059	10218	9396	9396
query79	1636	830	580	580
query80	594	522	463	463
query81	497	258	212	212
query82	198	128	93	93
query83	178	174	151	151
query84	235	93	71	71
query85	749	350	374	350
query86	359	322	292	292
query87	4484	4517	4303	4303
query88	3397	2251	2275	2251
query89	379	320	284	284
query90	1914	215	208	208
query91	143	144	113	113
query92	75	64	59	59
query93	1529	1074	586	586
query94	673	421	296	296
query95	346	273	263	263
query96	477	564	276	276
query97	3285	3383	3329	3329
query98	229	201	208	201
query99	1332	1407	1275	1275
Total cold run time: 273891 ms
Total hot run time: 186519 ms

@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 32559 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5a244021904d1f471fad47eccb9feea9162efe09, data reload: false

------ Round 1 ----------------------------------
q1	17605	5216	5074	5074
q2	2050	305	158	158
q3	10408	1289	687	687
q4	10221	1017	520	520
q5	7562	2662	2342	2342
q6	186	161	130	130
q7	903	749	607	607
q8	9307	1314	1036	1036
q9	5027	4775	4905	4775
q10	6821	2306	1906	1906
q11	469	281	254	254
q12	336	343	217	217
q13	17765	3673	3075	3075
q14	226	238	205	205
q15	536	485	480	480
q16	624	619	598	598
q17	575	881	340	340
q18	7240	6505	6466	6466
q19	1215	965	548	548
q20	307	327	199	199
q21	2881	2151	1949	1949
q22	1019	1046	993	993
Total cold run time: 103283 ms
Total hot run time: 32559 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5149	5133	5156	5133
q2	248	331	233	233
q3	2154	2673	2286	2286
q4	1452	1822	1388	1388
q5	4225	4156	4152	4152
q6	205	173	125	125
q7	1874	1851	1674	1674
q8	2545	2605	2509	2509
q9	6843	6912	6837	6837
q10	2876	3069	2657	2657
q11	563	501	485	485
q12	697	740	581	581
q13	3350	3663	3096	3096
q14	266	299	257	257
q15	532	470	472	470
q16	628	664	625	625
q17	1116	1571	1308	1308
q18	7269	7130	7177	7130
q19	802	783	804	783
q20	1929	1972	1812	1812
q21	5198	4760	4655	4655
q22	1057	1033	995	995
Total cold run time: 50978 ms
Total hot run time: 49191 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186308 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5a244021904d1f471fad47eccb9feea9162efe09, data reload: false

query1	997	396	370	370
query2	6519	1899	1837	1837
query3	6793	221	220	220
query4	26117	23723	22937	22937
query5	5525	671	492	492
query6	318	199	186	186
query7	4593	490	312	312
query8	304	252	236	236
query9	8632	2633	2635	2633
query10	533	313	267	267
query11	15556	16554	14948	14948
query12	171	115	107	107
query13	1658	545	395	395
query14	11670	6804	6516	6516
query15	255	192	168	168
query16	7802	579	446	446
query17	1520	701	543	543
query18	2032	403	326	326
query19	257	185	155	155
query20	123	112	110	110
query21	209	124	104	104
query22	4303	4646	4472	4472
query23	33995	33254	32972	32972
query24	6924	2402	2452	2402
query25	504	442	389	389
query26	1172	259	160	160
query27	2103	498	334	334
query28	3965	2444	2400	2400
query29	639	551	433	433
query30	286	220	193	193
query31	927	902	784	784
query32	74	65	65	65
query33	561	365	322	322
query34	799	855	519	519
query35	791	830	753	753
query36	966	998	897	897
query37	122	99	72	72
query38	4182	4214	4189	4189
query39	1475	1404	1377	1377
query40	210	116	102	102
query41	55	54	54	54
query42	114	100	106	100
query43	501	517	489	489
query44	1345	817	801	801
query45	177	177	168	168
query46	833	1031	639	639
query47	1758	1777	1713	1713
query48	407	423	313	313
query49	801	551	439	439
query50	692	727	412	412
query51	4175	4229	4195	4195
query52	111	106	91	91
query53	236	264	187	187
query54	495	493	470	470
query55	87	76	79	76
query56	267	275	245	245
query57	1165	1147	1074	1074
query58	245	241	247	241
query59	2651	2641	2665	2641
query60	290	268	265	265
query61	118	118	118	118
query62	802	758	678	678
query63	243	192	196	192
query64	4213	1015	667	667
query65	4448	4354	4361	4354
query66	1005	410	294	294
query67	15821	15572	15372	15372
query68	8288	877	506	506
query69	547	300	264	264
query70	1238	1143	1152	1143
query71	505	303	278	278
query72	5661	3601	3796	3601
query73	780	748	354	354
query74	8934	9198	8701	8701
query75	3927	3170	2706	2706
query76	3726	1204	793	793
query77	798	362	290	290
query78	10104	10137	9372	9372
query79	3198	843	592	592
query80	597	543	439	439
query81	502	269	222	222
query82	723	126	100	100
query83	178	169	149	149
query84	240	100	75	75
query85	818	358	315	315
query86	366	307	277	277
query87	4436	4612	4438	4438
query88	3708	2275	2271	2271
query89	456	318	282	282
query90	1946	216	224	216
query91	156	136	111	111
query92	76	62	55	55
query93	1873	1107	593	593
query94	673	425	308	308
query95	355	274	269	269
query96	486	579	279	279
query97	3297	3460	3369	3369
query98	231	208	209	208
query99	1395	1382	1301	1301
Total cold run time: 278855 ms
Total hot run time: 186308 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5a244021904d1f471fad47eccb9feea9162efe09, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.63	0.10	0.10
query5	0.56	0.55	0.54
query6	1.16	0.72	0.71
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.58	0.53	0.51
query10	0.56	0.61	0.58
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.61	0.59
query14	2.80	2.82	2.80
query15	0.92	0.84	0.87
query16	0.36	0.37	0.38
query17	1.04	1.01	1.05
query18	0.21	0.20	0.20
query19	1.91	1.95	1.81
query20	0.01	0.01	0.01
query21	15.35	0.90	0.55
query22	0.77	1.20	1.03
query23	14.68	1.39	0.66
query24	7.22	1.28	0.50
query25	0.55	0.22	0.20
query26	0.61	0.15	0.14
query27	0.05	0.04	0.05
query28	9.63	0.89	0.43
query29	12.58	4.08	3.33
query30	0.26	0.10	0.06
query31	2.81	0.59	0.39
query32	3.23	0.54	0.46
query33	3.08	3.02	3.13
query34	15.81	5.10	4.46
query35	4.52	4.55	4.51
query36	0.67	0.50	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.35 s
Total hot run time: 31.04 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 47.89% (12804/26736)
Line Coverage 37.29% (109256/292958)
Region Coverage 36.40% (55949/153697)
Branch Coverage 31.71% (28207/88942)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants