Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [Fix](sc) Don't save base tablet's compaction jobs to new tablet's TabletJobInfoPB #48960 #49035

Merged
merged 1 commit into from
Mar 14, 2025
Merged

branch-3.0: [Fix](sc) Don't save base tablet's compaction jobs to new tablet's TabletJobInfoPB #48960 #49035

merged 1 commit into from
Mar 14, 2025
+11 −1

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #48960

@github-actions github-actions bot requested a review from dataroaring as a code owner March 13, 2025 09:17
@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 13, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 13, 2025

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 83.17% (1072/1289)
Line Coverage: 65.99% (17677/26789)
Region Coverage: 65.48% (8706/13296)
Branch Coverage: 55.39% (4697/8480)
Coverage Report: http://coverage.selectdb-in.cc/coverage/941725b3b6a15fc90038bf82d2801ad1ca946181_941725b3b6a15fc90038bf82d2801ad1ca946181_cloud/report/index.html

dataroaring
dataroaring approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 14, 2025
@github-actions GitHub Actions
Copy link
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor Author

PR approved by anyone and no changes requested.

@bobhan1
Copy link
Contributor

bobhan1 commented Mar 14, 2025

run cloud_p0

@dataroaring dataroaring merged commit c9e3e18 into branch-3.0 Mar 14, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48960-branch-3.0 branch March 14, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thearas @doris-robot @bobhan1 @dataroaring