-
Notifications
You must be signed in to change notification settings - Fork 750
GUACAMOLE-2055: Add Turkish translation and keyboard layout. #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Turab : I haven't reviewed the actual changes, yet, but, just looking at the pull request, the commit messages need some work:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few general comments for the translations:
- For items that you are not providing translations, you can exclude them from the
tr.json
files completely - the translation system will automatically fall back to the English translations. - If you are translating them, and the Turkish translation just happens to be identical to the English translation, please do include those.
- Please make sure to put/keep the items in alphabetical order - e.g.
INFO_A
should be beforeINFO_B
.
extensions/guacamole-auth-duo/src/main/resources/translations/tr.json
Outdated
Show resolved
Hide resolved
extensions/guacamole-auth-json/src/main/resources/translations/tr.json
Outdated
Show resolved
Hide resolved
extensions/guacamole-auth-ldap/src/main/resources/translations/tr.json
Outdated
Show resolved
Hide resolved
extensions/guacamole-auth-quickconnect/src/main/resources/translations/tr.json
Show resolved
Hide resolved
extensions/guacamole-auth-radius/src/main/resources/translations/tr.json
Outdated
Show resolved
Hide resolved
extensions/guacamole-auth-restrict/src/main/resources/translations/tr.json
Outdated
Show resolved
Hide resolved
...s/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/translations/tr.json
Outdated
Show resolved
Hide resolved
extensions/guacamole-auth-totp/src/main/resources/translations/tr.json
Outdated
Show resolved
Hide resolved
c83c96a
to
fa6e239
Compare
4568904
to
f9e2653
Compare
I removed the tr.json files and their reference in manifest files where the only string was the exact same equivalent with English and I squahsed all the commit. |
…nd removal of one empty string
No description provided.