Skip to content

GUACAMOLE-2055: Add Turkish translation and keyboard layout. #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Turab
Copy link

@Turab Turab commented Apr 16, 2025

No description provided.

@Turab Turab changed the title Add Turkish translation GUACAMOLE-2055: Add Turkish translation Apr 17, 2025
@necouchman
Copy link
Contributor

@Turab : I haven't reviewed the actual changes, yet, but, just looking at the pull request, the commit messages need some work:

  • Each commit message needs the GUACAMOLE-2055: tag prepended to it.
  • The commit messages need to be descriptive of the actual changes, beyond just things like Fix typo, etc. If you have trouble generating a commit message that's not an exact description of the changes made (Fix typo on line 31 in file tr.json), then consider squashing commits together. For some examples and hints, we recommend the following page: https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/.

Copy link
Contributor

@necouchman necouchman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few general comments for the translations:

  • For items that you are not providing translations, you can exclude them from the tr.json files completely - the translation system will automatically fall back to the English translations.
  • If you are translating them, and the Turkish translation just happens to be identical to the English translation, please do include those.
  • Please make sure to put/keep the items in alphabetical order - e.g. INFO_A should be before INFO_B.

@Turab Turab force-pushed the turkish-translation branch from c83c96a to fa6e239 Compare April 22, 2025 11:29
@Turab Turab changed the title GUACAMOLE-2055: Add Turkish translation GUACAMOLE-2055: Add Turkish translation and keyboard layout. Apr 22, 2025
@Turab Turab requested a review from necouchman April 22, 2025 11:31
@Turab Turab force-pushed the turkish-translation branch from 4568904 to f9e2653 Compare April 22, 2025 12:07
@Turab
Copy link
Author

Turab commented Apr 22, 2025

I removed the tr.json files and their reference in manifest files where the only string was the exact same equivalent with English and I squahsed all the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants