GUACAMOLE-1374: Migrate to LOG_LEVEL and modular Docker build. #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattieb
reviewed
Apr 19, 2025
necouchman
reviewed
Apr 21, 2025
|
Just one comment from me, plus the one that @mattieb mentioned above, and this should be ready to merge. |
…d for 3.x and default for all versions).
…s (not necessarily tested, especially 32-bit).
mike-jumper
force-pushed
the
modular-docker
branch
from
0fca110 to
d9ff15e
Compare
|
Went ahead and added |
necouchman
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change migrates to a Docker build leveraging multiple modular stages that cover each of guacamole-server's dependencies, avoiding unnecessary recompilation of dependencies that are not changing (something that is slowing down rebuilds for testing quite a bit, particularly if any download from GitHub times out).
For consistency's sake, I've also added a
LOG_LEVELvariable to replaceGUACD_LOG_LEVEL, in line with the guacamole-client image.