GUACAMOLE-1026: Correct inverted performance flag logic.

[mike-jumper]

This change corrects the regression in handling of FreeRDP 3.x performance flags. Apparently, we simply inverted the logic through the magic of copypasta.

[necouchman]

@mike-jumper The build seems to be failing with some messages regarding codecs:

/opt/guacamole/lib/pkgconfig/../../include/freerdp3/freerdp/codecs.h:93:9: error: 'codecs_free' is deprecated: [since 3.6.0] Use freerdp_client_codecs_free [-Werror=deprecated-declarations]
#9 221.2    93 |         WINPR_DEPRECATED_VAR("[since 3.6.0] Use freerdp_client_codecs_new",
#9 221.2       |         ^~~~~~~~~~~~~~~~~~~~

[mike-jumper]

@necouchman Interestingly, we're not actually calling the functions warned about there. It looks like GCC just universally issues warnings for anything including the codecs.h header (which is effectively everything via freerdp.h).

I've opened FreeRDP/FreeRDP#11412 for the warnings, though am not sure this is intentional behavior on GCC's part.

[necouchman]

@necouchman Interestingly, we're not actually calling the functions warned about there. It looks like GCC just universally issues warnings for anything including the codecs.h header (which is effectively everything via freerdp.h).

I've opened FreeRDP/FreeRDP#11412 for the warnings, though am not sure this is intentional behavior on GCC's part.

Okay - so are you comfortable moving forward with this merge even with the build failing? Or do you want to wait until that's sorted?

[mike-jumper]

I think it's OK to move forward and possibly address the build failure separately (or rely instead on adding build flags until it's no longer an issue).