-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-7750][VL]: store unsafe batches data #7902
Draft
Zand100
wants to merge
2
commits into
apache:main
Choose a base branch
from
Zand100:Zand100/unsafe-array2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
backends-velox/src/main/scala/org/apache/spark/sql/execution/UnsafeArray.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
package org.apache.spark.sql.execution | ||
|
||
import org.apache.spark.memory.{MemoryConsumer, MemoryMode, SparkOutOfMemoryError, TaskMemoryManager} | ||
import org.apache.spark.sql.catalyst.expressions.UnsafeArrayData | ||
import org.apache.spark.unsafe.{Platform, UnsafeAlignedOffset} | ||
import org.apache.spark.unsafe.memory.MemoryBlock | ||
|
||
class UnsafeArray(taskMemoryManager: TaskMemoryManager) extends MemoryConsumer(taskMemoryManager, MemoryMode.OFF_HEAP) { | ||
|
||
protected var page: MemoryBlock = null | ||
acquirePage(taskMemoryManager.pageSizeBytes) | ||
protected var base: AnyRef = page.getBaseObject | ||
protected var pageCursor = 0 | ||
private var keyOffsets: Array[Long] = null | ||
protected var numRows = 0 | ||
|
||
def iterator() {} | ||
|
||
private def acquirePage(requiredSize: Long): Boolean = { | ||
try page = allocatePage(requiredSize) | ||
|
||
catch { | ||
case SparkOutOfMemoryError => | ||
return false | ||
} | ||
base = page.getBaseObject | ||
pageCursor = 0 | ||
true | ||
} | ||
|
||
def get(rowId: Int): UnsafeArrayData = { | ||
val offset = keyOffsets(rowId) | ||
val klen = UnsafeAlignedOffset.getSize(base, offset - UnsafeAlignedOffset.getUaoSize) | ||
val result = new UnsafeArrayData | ||
result.pointTo (base, offset, klen) | ||
result | ||
} | ||
|
||
def write(bytes: Array[Byte], inputOffset: Long, inputLength: Int): Unit = { | ||
var offset: Long = page.getBaseOffset + pageCursor | ||
val recordOffset = offset | ||
|
||
val uaoSize = UnsafeAlignedOffset.getUaoSize | ||
|
||
val recordLength = 2L * uaoSize + inputLength + 8L | ||
|
||
UnsafeAlignedOffset.putSize(base, offset, inputLength + uaoSize) | ||
offset += 2L * uaoSize | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if I'm calculating the |
||
Platform.copyMemory(bytes, inputOffset, base, offset, inputLength) | ||
Platform.putLong(base, offset, 0) | ||
|
||
pageCursor += recordLength | ||
keyOffsets(numRows) = recordOffset + 2L * uaoSize; | ||
numRows += 1 | ||
} | ||
|
||
override def spill(l: Long, memoryConsumer: MemoryConsumer): Long = ??? | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhztheplayer Is it alright to create the
ColumnarBatch
this way, usingOffHeapColumnVector
and constructing a newColumnarBatch
directly from that?