Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VL] Branch 1.2: Backport fixes for #7243 #7943

Open
wants to merge 6 commits into
base: branch-1.2
Choose a base branch
from
Open

[VL] Branch 1.2: Backport fixes for #7243 #7943

wants to merge 6 commits into from
+147 −85

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Nov 14, 2024 •
edited
Loading

Backport fixes for #7243.

The work is partly based on previous efforts #7921 and #7648.

Fixes for #6736 are not included, and #7165 is ported as a temporary solution.

@zhztheplayer zhztheplayer changed the title [VL] Branch 1.2: Backport fixes for #7243 [VL] Branch 1.2: Backport fixes for https://github.com/apache/incubator-gluten/issues/7243 Nov 14, 2024
@zhztheplayer zhztheplayer changed the title [VL] Branch 1.2: Backport fixes for https://github.com/apache/incubator-gluten/issues/7243 [VL] Branch 1.2: Backport fixes for #7243 Nov 14, 2024
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@apache apache deleted a comment from github-actions bot Nov 14, 2024
@zhztheplayer
Copy link
Member Author

cc @wForget @zsmj2017

@zhztheplayer
Copy link
Member Author

zhztheplayer commented Nov 14, 2024 •
edited
Loading

@wForget @zsmj2017

Would you want to help verify this since CI is passing now, thanks.

@zsmj2017
Copy link

@wForget @zsmj2017

Would you want to help verify this since CI is passing now, Thanks.

I am testing some spill hang etls and will give response in 2024/11/15

@wForget
Copy link
Member

wForget commented Nov 15, 2024

@wForget @zsmj2017

Would you want to help verify this since CI is passing now, thanks.

Thank you, I will verify this later.

@zsmj2017
Copy link

@wForget @zsmj2017
Would you want to help verify this since CI is passing now, Thanks.

I am testing some spill hang etls and will give response in 2024/11/15

@zhztheplayer
Based on the tests, the previously stable spill-hang job no longer hangs.（5/5 jobs passed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhztheplayer @zsmj2017 @wForget @Yohahaha