Skip to content

BREAKING: Remove SystemConsole class, #920, #936 #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Removes the SystemConsole class from Lucene.NET.

Related: #920, #936

Description

#920 had an item for adding unit tests for SystemConsole, but after discussion with @NightOwl888, we determined that this class is not needed in Lucene.NET, and only serves as an unnecessary abstraction. Users that wish to override the Console.Out/Error behavior can use Console.SetOut or Console.SetError to replace them with a different TextWriter. Most of the usage is in tests anyways, and the usage in non-test code is behind VERBOSE flags.

#936 raised an issue with MAUI support, but this was only a problem with Console.In. Console.Out and Console.Error work fine in MAUI.

This is a breaking change because SystemConsole was previously public.

@paulirwin paulirwin added the notes:breaking-change Has changes that will break backward compatibility label Jan 21, 2025
@paulirwin paulirwin requested a review from NightOwl888 January 21, 2025 04:39
Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

We can now remove FEATURE_ARGITERATOR, since it only existed in SystemConsole.

@paulirwin paulirwin requested a review from NightOwl888 January 21, 2025 15:07
@paulirwin paulirwin mentioned this pull request Jan 21, 2025
19 tasks
@paulirwin paulirwin merged commit ab73b08 into apache:master Jan 21, 2025
267 checks passed
@paulirwin paulirwin deleted the issue/920-remove-systemconsole branch January 21, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:breaking-change Has changes that will break backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants