BREAKING: Remove SystemConsole class, #920, #936 #1113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the SystemConsole class from Lucene.NET.
Related: #920, #936
Description
#920 had an item for adding unit tests for SystemConsole, but after discussion with @NightOwl888, we determined that this class is not needed in Lucene.NET, and only serves as an unnecessary abstraction. Users that wish to override the Console.Out/Error behavior can use Console.SetOut or Console.SetError to replace them with a different TextWriter. Most of the usage is in tests anyways, and the usage in non-test code is behind VERBOSE flags.
#936 raised an issue with MAUI support, but this was only a problem with Console.In. Console.Out and Console.Error work fine in MAUI.
This is a breaking change because SystemConsole was previously public.