Skip to content

BREAKING: Move CrankyTokenFilter to Lucene.Net.Analysis namespace (#1127) #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NehanPathan
Copy link
Contributor


Summary of the changes

Moved CrankyTokenFilter to the correct namespace Lucene.Net.Analysis.


📝 Fixes

Fixes #1127


📚 Description

This pull request addresses issue #1127 by moving CrankyTokenFilter from the incorrect namespace:

  • Old Namespace: Lucene.Net.TestFramework.Analysis.CrankyTokenFilter
  • New Namespace: Lucene.Net.Analysis

Details:

  • Updated the CrankyTokenFilter class to reside in the Lucene.Net.Analysis namespace, aligning it with the correct package as in the original Lucene project (org.apache.lucene.analysis).
  • Ensured that the class remains in the TestFramework project and was not moved to Lucene.Net.Analysis.Common.
  • Adjusted any necessary using statements and references.

🧪 Tests

  • Unit tests covering CrankyTokenFilter have been run successfully.
  • Verified that all tests related to this change pass without regression.

📚 Documentation

  • Updated inline comments where necessary to reflect the namespace change.
  • No public-facing documentation changes required.

🎯 Checklist


🔥 Ready to Merge!

This change ensures that the project structure remains consistent with the original Lucene package, maintaining correctness and improving maintainability.

Thank you for reviewing! 😊🚀

@paulirwin paulirwin self-requested a review March 18, 2025 21:51
@paulirwin paulirwin self-assigned this Mar 18, 2025
Copy link
Contributor

@paulirwin paulirwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, this looks good! And congratulations on your first contribution to Lucene.NET!

@paulirwin paulirwin added the notes:breaking-change Has changes that will break backward compatibility label Mar 19, 2025
@paulirwin paulirwin changed the title Move CrankyTokenFilter to Lucene.Net.Analysis namespace (#1127) BREAKING: Move CrankyTokenFilter to Lucene.Net.Analysis namespace (#1127) Mar 19, 2025
@paulirwin paulirwin merged commit 3729d32 into apache:master Mar 19, 2025
273 checks passed
@NehanPathan NehanPathan deleted the bugfix/crankytokenfilter-namespace-fix branch March 19, 2025 16:23
@NehanPathan
Copy link
Contributor Author

NehanPathan commented Mar 26, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:breaking-change Has changes that will break backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move CrankyTokenFilter to the Lucene.Net.Analysis namespace
2 participants