RATIS-2244. Reduce the number of log messages during bootstrap #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szetszwo
reviewed
Feb 2, 2025
There was a problem hiding this comment.
@venkatsambath , thanks for the update! Please see the comment inlined.
| @@ -45,7 +45,7 @@ default TimeDuration getBatchDuration() { | |||
|
|
|||
| private static final class UniqueId { | |||
| private final Key key; | |||
| private final String name; | |||
| private final Object name; | |||
|
|
|||
| private UniqueId(Key key, String name) { | |||
There was a problem hiding this comment.
Please change the class of name to Object. I forgot to do it in my review.
There was a problem hiding this comment.
Sure, I've updated the class from string to object now and updated the commit. fb0b266
szetszwo
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one of the Ozone OM falls back and bootstraps, the logs are printed very frequently and it rolls off 30 log files (of 200MB each) in 15 mins. Since logs are rolled off too quick, troubleshooting cause of bootstrap is becoming difficult.
What changes were proposed in this pull request?
Updated the logging to BatchLogger using the review patch from @szetszwo #1216 - I closed that pull request by mistake.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2244
How was this patch tested?
Logging change. Didnt create unit test for this change.