-
Notifications
You must be signed in to change notification settings - Fork 379
Add sessions
subpackage
#108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbuchar
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation is super nice, I like how you split the (de)serialization from the business logic. I found a bunch of things to nitpick though 🙂
janbuchar
reviewed
Apr 15, 2024
janbuchar
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Session
&SessionPool
.SessionPool
can be persisted into KVS, Pydantic models are utilized for this case.CookiesType
union withhttp.cookie_jar.CookieJar
,httpx.Cookies
, and dictionary, but these types were not serializable by Pydantic. However, both can be converted to dictionaries, so there should be no problem with cookies being adict
type.EventManager
, which now functions as a context manager (same asLocalEventManager
).Issue
Tests