Skip to content

chore: update base image for appsmith #40058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025

Conversation

pratapaprasanna
Copy link
Contributor

@pratapaprasanna pratapaprasanna commented Apr 3, 2025

Summary by CodeRabbit

  • Chores
    • Updated system base image to Ubuntu 24.04.
    • Upgraded MongoDB to version 6.0 and PostgreSQL to version 14 for improved compatibility and security.
    • Improved package installation process for reliability.

Warning

Tests have not run on the HEAD cc483c3 yet


Sun, 27 Apr 2025 11:34:21 UTC

Copy link
Contributor

coderabbitai bot commented Apr 3, 2025

Walkthrough

The Docker base image was updated from Ubuntu 20.04 to Ubuntu 24.04. MongoDB was upgraded from version 5.0 to 6.0, with its GPG key management and repository configuration modernized. The PostgreSQL version was increased from 13 to 14, and its installation command was adjusted for non-interactive execution. Redis installation remained unchanged. Overall, the Dockerfile's package installation steps were revised to accommodate these version and key management updates.

Changes

File(s) Change Summary
deploy/docker/base.dockerfile Updated base image to Ubuntu 24.04; upgraded MongoDB from 5.0 to 6.0 with new key handling; updated MongoDB repo source; upgraded PostgreSQL from 13 to 14 with non-interactive install; package installation steps adjusted.

Poem

Upgraded our Docker base, so bright and new,
Ubuntu twenty-four, with packages in view.
Mongo and Postgres, both leveled up high,
Secure keys and sources, reaching for the sky.
Our containers now fresher, ready to deploy—
A modernized stack for all to enjoy! 🚀


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 2134224 and cc483c3.

📒 Files selected for processing (1)
  • deploy/docker/base.dockerfile (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • deploy/docker/base.dockerfile

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Apr 3, 2025
@pratapaprasanna
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

Copy link

github-actions bot commented Apr 3, 2025

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14238032020.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 40058.
recreate: .

Copy link

github-actions bot commented Apr 3, 2025

Deploy-Preview-URL: https://ce-40058.dp.appsmith.com

Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Apr 10, 2025
@pratapaprasanna
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14446435369.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 40058.
recreate: .

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
deploy/docker/base.dockerfile (2)

24-26: Upgrade MongoDB Repository and Key Management

The MongoDB installation commands have been updated to install v6.0. The repository entry now uses the "jammy" codename and leverages a signed key stored at /usr/share/keyrings/mongodb-server-6.0.gpg for improved security. This update aligns with modern best practices.


28-28: Consider Updating Deprecated Apt-Key Usage

While the MongoDB key setup now uses gpg --dearmor, the PostgreSQL key is still added via apt-key add -, which is deprecated. Consider updating this method for consistency and future compatibility.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 2f1f212 and 68ac660.

📒 Files selected for processing (2)
  • Dockerfile (1 hunks)
  • deploy/docker/base.dockerfile (2 hunks)
🔇 Additional comments (3)
deploy/docker/base.dockerfile (2)

6-6: Updated Base Image

The base image has been updated to Ubuntu 22.04 as required by the PR. Please verify that all system dependencies and installed packages fully support this newer OS version.


30-30: Enforce Non-Interactive Installation

The installation command for mongodb-org, redis, and postgresql-14 now utilizes the DEBIAN_FRONTEND=noninteractive flag, reducing potential interactive prompts during the build. This change is well implemented.

Dockerfile (1)

2-2: Fixed Base Image Usage

The Dockerfile now directly specifies the base image as gouthamappsmith/appsmith_base:0.0.1 instead of relying on the BASE argument. This ensures consistent builds. Please verify that all dependent components are compatible with this fixed image.

Copy link

Deploy-Preview-URL: https://ce-40058.dp.appsmith.com

@pratapaprasanna pratapaprasanna force-pushed the chore/security/update/appsmith/base/image branch from 68ac660 to 95705df Compare April 14, 2025 13:33
@pratapaprasanna
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14447029822.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 40058.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-40058.dp.appsmith.com

@github-actions github-actions bot removed the Stale label Apr 14, 2025
@pratapaprasanna
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14464804923.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 40058.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-40058.dp.appsmith.com

Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Apr 22, 2025
@pratapaprasanna pratapaprasanna force-pushed the chore/security/update/appsmith/base/image branch from 2134224 to cedc637 Compare April 27, 2025 11:32
@pratapaprasanna pratapaprasanna merged commit d64087f into release Apr 28, 2025
20 checks passed
@pratapaprasanna pratapaprasanna deleted the chore/security/update/appsmith/base/image branch April 28, 2025 05:41
@coderabbitai coderabbitai bot mentioned this pull request May 15, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant