-
Notifications
You must be signed in to change notification settings - Fork 4.1k
chore: update base image for appsmith #40058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update base image for appsmith #40058
Conversation
WalkthroughThe Docker base image was updated from Ubuntu 20.04 to Ubuntu 24.04. MongoDB was upgraded from version 5.0 to 6.0, with its GPG key management and repository configuration modernized. The PostgreSQL version was increased from 13 to 14, and its installation command was adjusted for non-interactive execution. Redis installation remained unchanged. Overall, the Dockerfile's package installation steps were revised to accommodate these version and key management updates. Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14238032020. |
Deploy-Preview-URL: https://ce-40058.dp.appsmith.com |
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14446435369. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
deploy/docker/base.dockerfile (2)
24-26
: Upgrade MongoDB Repository and Key ManagementThe MongoDB installation commands have been updated to install v6.0. The repository entry now uses the "jammy" codename and leverages a signed key stored at
/usr/share/keyrings/mongodb-server-6.0.gpg
for improved security. This update aligns with modern best practices.
28-28
: Consider Updating Deprecated Apt-Key UsageWhile the MongoDB key setup now uses
gpg --dearmor
, the PostgreSQL key is still added viaapt-key add -
, which is deprecated. Consider updating this method for consistency and future compatibility.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)
📒 Files selected for processing (2)
Dockerfile
(1 hunks)deploy/docker/base.dockerfile
(2 hunks)
🔇 Additional comments (3)
deploy/docker/base.dockerfile (2)
6-6
: Updated Base ImageThe base image has been updated to Ubuntu 22.04 as required by the PR. Please verify that all system dependencies and installed packages fully support this newer OS version.
30-30
: Enforce Non-Interactive InstallationThe installation command for
mongodb-org
,redis
, andpostgresql-14
now utilizes theDEBIAN_FRONTEND=noninteractive
flag, reducing potential interactive prompts during the build. This change is well implemented.Dockerfile (1)
2-2
: Fixed Base Image UsageThe Dockerfile now directly specifies the base image as
gouthamappsmith/appsmith_base:0.0.1
instead of relying on theBASE
argument. This ensures consistent builds. Please verify that all dependent components are compatible with this fixed image.
Deploy-Preview-URL: https://ce-40058.dp.appsmith.com |
68ac660
to
95705df
Compare
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14447029822. |
Deploy-Preview-URL: https://ce-40058.dp.appsmith.com |
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14464804923. |
Deploy-Preview-URL: https://ce-40058.dp.appsmith.com |
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
2134224
to
cedc637
Compare
Summary by CodeRabbit
Warning
Tests have not run on the HEAD cc483c3 yet
Sun, 27 Apr 2025 11:34:21 UTC