Skip to content

chore: Adjust nested paddings in markdown #40260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025

Conversation

ichik
Copy link
Contributor

@ichik ichik commented Apr 15, 2025

Description

Part of https://github.com/appsmithorg/appsmith-ee/pull/7148

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14471353200
Commit: 08688d9
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Tue, 15 Apr 2025 14:42:20 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Style
    • Improved indentation for list items in markdown content, increasing left margin for nested lists to enhance readability.

@ichik ichik requested review from jsartisan and hetunandu April 15, 2025 13:57
@ichik ichik requested a review from a team as a code owner April 15, 2025 13:57
Copy link
Contributor

coderabbitai bot commented Apr 15, 2025

Walkthrough

The CSS for the markdown component's list items was modified to adjust their left margin. The update sets a 0.5em left margin for all list items and introduces a specific rule to apply a 1em left margin for list items that are direct children of nested unordered or ordered lists. No changes were made to exported or public entities.

Changes

File(s) Change Summary
app/client/packages/design-system/widgets/src/components/Markdown/src/styles.module.css Updated CSS: set 0.5em left margin for all li, and 1em left margin for nested li in ul or ol

Suggested labels

skip-changelog, WDS team, ok-to-test

Suggested reviewers

  • jsartisan
  • danielmorris-as
  • hetunandu

Poem

Lists now march with tidy grace,
Margins set to find their place.
Nested items shift with pride,
Indented just a bit more wide.
CSS whispers, “Align, align!”
Markdown lists now look divine.
🎨✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3dfc817 and 08688d9.

📒 Files selected for processing (1)
  • app/client/packages/design-system/widgets/src/components/Markdown/src/styles.module.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: client-build / client-build
  • GitHub Check: chromatic-deployment
  • GitHub Check: chromatic-deployment
  • GitHub Check: storybook-tests
🔇 Additional comments (2)
app/client/packages/design-system/widgets/src/components/Markdown/src/styles.module.css (2)

82-82: List item margin updated for clarity.

The new margin-left: 0.5em; for all li elements is a sensible default for markdown readability.


88-90: Nested list indentation improved.

The selector for nested list items (> :is(ul, ol) > li) with margin-left: 1em; is a clean way to visually separate nested lists. No issues here.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Apr 15, 2025
@ichik ichik added the ok-to-test Required label for CI label Apr 15, 2025
@hetunandu
Copy link
Member

This PR is unnecessary as the CE PR already exists and testing can happen on the PR against cp/ai-agents

@ichik ichik merged commit d8cf437 into release Apr 16, 2025
54 checks passed
@ichik ichik deleted the chore/adjust-agent-chat-responsive-paddings branch April 16, 2025 06:54
@coderabbitai coderabbitai bot mentioned this pull request Apr 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants