fix: Bad mixpanel config arising from env

[hetunandu]

Description

Earlier we were only checking for segment enabled to turn on mixpanel. But an error happened when segment was enabled on a deployment but mixpanel key was not present. This cause mixpanel config to be true but without a key

To avoid this, we will also confirm mixpanel key exists and not just segment

/ok-to-test tags="@tag.Sanity"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14474665480
Commit: 2edc7ce
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Tue, 15 Apr 2025 17:18:28 UTC

Summary by CodeRabbit

• Bug Fixes
  • Improved accuracy of Mixpanel tracking settings, ensuring Mixpanel is only enabled when both Segment and Mixpanel tracking are enabled.

[coderabbitai]

Walkthrough

The update refines the logic within the getAppsmithConfigs function in app/client/src/ce/configs/index.ts. Now, the Mixpanel tracking configuration is enabled only if both the Segment tracking and Mixpanel flags are set to true. This introduces a stricter requirement for enabling Mixpanel, ensuring that both conditions must be satisfied.

Changes

File(s)	Change Summary
app/client/src/ce/configs/index.ts	Updated logic for Mixpanel tracking enablement to require both Segment and Mixpanel flags to be true.

Poem

When toggles align and configs combine,
Mixpanel awaits for the stars to shine.
Segment and Mixpanel, both must agree,
Before tracking’s enabled, as clear as can be!
Logic refined, in code it’s displayed—
Two flags united, analytics conveyed.
🎉

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3dfc817 and 2edc7ce.

📒 Files selected for processing (1)

• app/client/src/ce/configs/index.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: client-build / client-build
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-prettier / prettier-check

🔇 Additional comments (1)

app/client/src/ce/configs/index.ts (1)

216-216: Improved Mixpanel configuration logic

This change ensures Mixpanel is only enabled when both Segment tracking is enabled AND Mixpanel has a valid API key. This fixes the issue where Mixpanel would be incorrectly enabled when Segment was enabled but the Mixpanel key was missing.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.