ci: Fixing the page actions spec

[ankitakinger]

Description

Fixing the page actions spec that was failing after #40322 merge

Fixes #

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Warning

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14588924487
Commit: d46229a
Cypress dashboard.
Tags: @tag.IDE
Spec:
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.

---

Tue, 22 Apr 2025 07:14:51 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Tests
  • Updated test assertions to check the "data-subtle" attribute instead of "data-disabled" when verifying the UI state of hidden pages.
  • Added a tag to the test suite for improved categorization.

[coderabbitai]

Walkthrough

The test suite for page actions in the client-side Cypress regression tests was updated to replace assertions checking the "data-disabled" attribute with checks for the "data-subtle" attribute on specific UI elements. The expected value for the attribute remains "true", and these assertions occur after hiding cloned pages and before deleting them. The top-level describe block was also modified to include a tag for test categorization. No other logic or exported entities were changed.

Changes

File(s)	Change Summary
app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts	Changed attribute assertions from "data-disabled" to "data-subtle" in tests; added test tag.

Possibly related PRs

• fix: Updating the UX for hidden pages #40322: Changes attribute checks from "data-disabled" to "data-subtle" in UI tests for hidden pages, directly related to the current update.

Suggested labels

Bug, IDE Product, IDE Pod, ok-to-test, Low

Suggested reviewers

• hetunandu

Poem

Pages hidden, subtle signs anew,
No longer "disabled"—a gentler view.
Cypress tests now tag and check,
For attributes that softly reflect.
With each assertion, clarity grows,
In the IDE, subtlety shows!
🌱✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ace9ba and d46229a.

📒 Files selected for processing (1)

• app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts (4 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`app/client/cypress/**/**.*`: Review the following e2e test code written using the Cypress test library. Ensure that: - Follow best practices for Cypress code and e2e automation. ...

app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

• Follow best practices for Cypress code and e2e automation.
• Avoid using cy.wait in code.
• Avoid using cy.pause in code.
• Avoid using agHelper.sleep().
• Use locator variables for locators and do not use plain strings.
• Use data-* attributes for selectors.
• Avoid Xpaths, Attributes and CSS path.
• Avoid selectors like .btn.submit or button[type=submit].
• Perform logins via API with LoginFromAPI.
• Perform logout via API with LogOutviaAPI.
• Perform signup via API with SignupFromAPI.
• Avoid using it.only.
• Avoid using after and aftereach in test cases.
• Use multiple assertions for expect statements.
• Avoid using strings for assertions.
• Do not use duplicate filenames even with different paths.
• Avoid using agHelper.Sleep, this.Sleep in any file in code.

• app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: perform-test / client-build / client-build
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-build / client-build
• GitHub Check: client-prettier / prettier-check

🔇 Additional comments (4)

app/client/cypress/e2e/Regression/ClientSide/PartialImportExport/PageActions_spec.ts (4)

18-18: Adding test tag is appropriate.

Adding the tag @tag.IDE to the describe block helps categorize and filter tests. This is a good practice for test organization.

---

33-37: Attribute assertion updated correctly.

The change from checking "data-disabled" to "data-subtle" appears to be a necessary update to match the current implementation of how hidden pages are displayed in the UI.

---

94-98: Attribute assertion updated correctly.

The attribute assertion has been consistently updated to check "data-subtle" instead of "data-disabled" for hidden pages, maintaining consistency with the previous change.

---

116-120: Attribute assertion updated correctly.

The third instance of the attribute assertion has been updated to check "data-subtle" instead of "data-disabled", ensuring consistency across all test cases for hidden pages.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.