-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix: add missing modText and isMacOrIOS mocks to fix CI test failures #40389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing modText and isMacOrIOS mocks to fix CI test failures #40389
Conversation
WalkthroughThis change reorganizes import statements within the test file for the Changes
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
…pplication and environment selectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock promotion
Description
This PR fixes the CI test failures in
useTableOrSpreadsheet.test.ts
by adding proper mocks for the modText and isMacOrIOS functions from the helpers module. While tests passed locally, they were failing in CI due to these missing mocks.Changes made:
Fixes #
Issue Number
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14664196489
Commit: 4f62c7a
Cypress dashboard.
Tags:
@tag.Sanity
Spec:
Fri, 25 Apr 2025 12:53:42 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Style
Tests