Skip to content

chore: fix height of reconnect modal #40399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Conversation

jsartisan
Copy link
Contributor

@jsartisan jsartisan commented Apr 25, 2025

Fixes #40391

/ok-to-test tags="@tag.ImportExport"

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Added support for an AI agent flow option in the SaaS datasource editor, enabling the editor to reflect the AI agent flow state in its interface.

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14703580804
Commit: 4a8429f
Cypress dashboard.
Tags: @tag.ImportExport
Spec:


Mon, 28 Apr 2025 08:58:04 UTC

@jsartisan jsartisan requested a review from ayushpahwa as a code owner April 25, 2025 12:17
Copy link
Contributor

coderabbitai bot commented Apr 25, 2025

Walkthrough

This update introduces support for an AI agent flow feature flag within the SaaS datasource editor component. It imports a Redux selector to obtain the AI agent flow enabled state and includes this value in the component's props via mapStateToProps. The flag is then passed to the DSEditorWrapper component through the editor's props interface, which is extended to include this optional boolean. No other logic or control flow is altered; the change is limited to state propagation and prop extension.

Changes

File(s) Change Summary
app/client/src/pages/Editor/SaaSEditor/DatasourceForm.tsx Imports getIsAiAgentFlowEnabled selector, adds isAiAgentFlowEnabled to mapStateToProps, extends SaasEditorWrappperProps interface, and passes the flag as a prop to DSEditorWrapper.

Assessment against linked issues

Objective Addressed Explanation
Show "Save & Authorise" button when importing agent app (#40391) The change only propagates the AI agent flow flag; it does not directly address button logic.

Possibly related PRs

Suggested labels

Low

Suggested reviewers

  • hetunandu

Poem

In the world of SaaS, a new flag appears,
AI agent flow now steers,
Through props it glides, Redux in tow,
To wrappers and editors, the feature will show.
No logic disturbed, just state on parade,
For future enhancements, the groundwork is laid!
🚩🤖


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between b52f07d and 4a8429f.

📒 Files selected for processing (1)
  • app/client/src/pages/Editor/SaaSEditor/DatasourceForm.tsx (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/src/pages/Editor/SaaSEditor/DatasourceForm.tsx
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-prettier / prettier-check

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jsartisan jsartisan requested a review from hetunandu April 25, 2025 12:17
@github-actions github-actions bot added AI Agents Issues related to agentic solutions on Appsmith Anvil Pod Issue related to Anvil project Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Production Release Blocker This issue must be resolved before the release skip-changelog Adding this label to a PR prevents it from being listed in the changelog and removed Bug Something isn't working labels Apr 25, 2025
@jsartisan jsartisan added the ok-to-test Required label for CI label Apr 25, 2025
@github-actions github-actions bot added Bug Something isn't working and removed Bug Something isn't working labels Apr 25, 2025
@jsartisan jsartisan force-pushed the chore/fix-import-modal-height branch from b52f07d to 4a8429f Compare April 28, 2025 08:26
@github-actions github-actions bot added Bug Something isn't working and removed Bug Something isn't working labels Apr 28, 2025
@jsartisan jsartisan merged commit 6e71588 into release Apr 28, 2025
45 checks passed
@jsartisan jsartisan deleted the chore/fix-import-modal-height branch April 28, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Agents Issues related to agentic solutions on Appsmith Anvil Pod Issue related to Anvil project High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Production Release Blocker This issue must be resolved before the release skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Save & Authorise" button not visible while importing agent app
2 participants