adapters: always loop until explicitly closed #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rambatino
reviewed
Apr 29, 2025
lukasmalkmus
force-pushed
the
lukasmalkmus/mmyxlkqozzqt
branch
from
9e2377f to
fc19a2c
Compare
lukasmalkmus
force-pushed
the
lukasmalkmus/mmyxlkqozzqt
branch
3 times, most recently
from
ba7391a to
b2ce6ed
Compare
Rambatino
approved these changes
May 6, 2025
lukasmalkmus
force-pushed
the
lukasmalkmus/mmyxlkqozzqt
branch
from
b2ce6ed to
ab0a1b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure our adapters never stop logging, even if they continuously hit errors.
Food for thought: Maybe this design means we should add error callback handlers so consumers have a chance to act on errors.