Skip to content

Unserialize cache data #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Unserialize cache data #1576

wants to merge 2 commits into from

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Mar 13, 2024

On redis driver, cache comes serialized
image
After unserialize
image

@systemsolutionweb systemsolutionweb mentioned this pull request Sep 9, 2024
Open
@barryvdh
Copy link
Owner

barryvdh commented May 9, 2025

Hmmm I'm not a fan of unserialize. Are we 100% sure the value is serialized by the driver? Because otherwise a string posing as a serialized string could lead to issues (eg https://www.invicti.com/blog/web-security/untrusted-data-unserialize-php/ and more)

@erikn69
Copy link
Contributor Author

erikn69 commented May 9, 2025

then it is better not to risk it

@erikn69 erikn69 closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systemsolutionweb systemsolutionweb systemsolutionweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikn69 @barryvdh @systemsolutionweb