Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add support for aliases to releases, release-groups and recordings.
This PR is a must have (IMO at least) for people that listen to Japanese, Chinese and other songs that has other symbols for letters. With this, not only the artist name will use the alias if available, but now the album and track name will also use aliases.
NOTE: This PR requires a fork of the
python-musicbrainzngs
package. That package seems to be dead (more than 2 years without any commit) and is lacking in a lot of updates to Musicbrainz API.Here is my PR adding support for the new fields alastair/python-musicbrainzngs#289 but I have no hope that will be merged since the package seems to be dead.
Personally I think beets can create a fork of that package and just add the bare minimum to it to make new features work (for example this one).
I didn't add any tests and changelog changes yet since this PR requires forking
python-musicbrainzngs
, so first I want to discuss if this can be merged and then after getting the confirmation I will add the missing parts.