Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve plugin crash when using nightly biome releases #112

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

walkerdb
Copy link
Contributor

fixes #111 by normalizing nightly biome package versions to the expected major.minor.patch format without the -nightly.hash postfix before splitting by ".".

@denbezrukov
Copy link
Contributor

@walkerdb Thank you! I'll merge it and release as a new nightly.

I'm wondering if we can release the next nightly version as the next.
Do you experience any other issues?

@denbezrukov denbezrukov merged commit 1c7850e into biomejs:main Dec 22, 2024
2 checks passed
@walkerdb
Copy link
Contributor Author

amazing thank you! No other issues that we've noticed

@walkerdb
Copy link
Contributor Author

walkerdb commented Dec 23, 2024

(also to note for my company's purposes we're unblocked either when this bugfix is published to the actual live plugin or biome 1.9.5 gets an official release, so we can move off the nightly. Either way works for us!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebStorm plugin crashes when using biome nightly releases
2 participants