Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): rename artifact with "intellij-biome-" instead "Biome-" prefix #81

Merged

Conversation

bc-m
Copy link
Contributor

@bc-m bc-m commented Aug 23, 2024

I don't know why, but the downloaded ZIP file has the prefix "intellij-biome-" instead of "Biome-" in GitHub Action "Publish to GitHub Releases":
https://github.com/biomejs/biome-intellij/actions/runs/10522456811/job/29155394740#step:5:17

Based on the github action log, I would have expected "Biome-":
https://github.com/biomejs/biome-intellij/actions/runs/10522456811/job/29155135022#step:10:23

When I download the artifact on my system, I get the file with a "Biome-" prefix:
https://github.com/biomejs/biome-intellij/actions/runs/10522456811/artifacts/1846129195

@bc-m bc-m marked this pull request as ready for review August 23, 2024 09:26
@ematipico
Copy link
Member

Yeah I noticed, that's weird. Thank you for fixing this.

As you noticed, we miss the maintainer that created the project. Your help will surely benefit a lot of users!

@ematipico ematipico merged commit b290a29 into biomejs:main Aug 23, 2024
2 checks passed
@APshenkin
Copy link
Contributor

@bc-m @ematipico seems publishing to Intellij Plugin Store is still not successful. Could it be because new tag wasn't created?

https://plugins.jetbrains.com/plugin/22761-biome

I downloaded plugin from github actions right now, and it works, but this is not handy for regular users :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants