Skip to content

Auto exposure and white balance loop: scale per-channel rgb gains so none exceed new parameter rgb_gain_limit #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

CitizenOneX
Copy link
Contributor

Per-channel (r, g, b) gains seem to contribute most to the row noise that presents in (rotated) images as vertical lines.
Rather than use the full range of r, g, b gain (0..1023), allow users of the auto exposure and white balance algorithm to set a cap on the rgb gain, and set a default on the low end of that range (141).

@CitizenOneX
Copy link
Contributor Author

I've made one correction, to scale the (max) normalized rgb value up to gain levels.
Previously the implementation had a set of gains 0..4 and a separate set of gains at 0..1023 for hardware level. To simplify the implementation I intended to scale all relevant values into this range but the normalized r, g, b values were missed.

Separately I've also initialized the "last" struct to start at a lower shutter value of 1600 again, it will ramp up if it needs to.

@uma-shankar-TE uma-shankar-TE mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant