[cachetools] add NewUploadWriter and tests #9406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-stowell
changed the title
vanja-p
approved these changes
May 21, 2025
| if uw.committed { | ||
| return nil | ||
| } | ||
| if uw.sendErr != nil { |
There was a problem hiding this comment.
sendErr could be EOF, right? In that case, do you still want to CloseAndRecv so you can get the committed size?
There was a problem hiding this comment.
- In
Commit(),CloseAndRecv()is still called even ifflush(..)returnsEOF. - In
Write(...), I opted to returnErrShortWriteinstead ofEOF. Tests do not seem to be hitting it. - Added test cases for the
UploadWriterpaths.
vanja-p
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces
NewUploadWriterand tests forUploadWriter. It leaves theUploadFromReaderpath untouched, since my first need forUploadWriteris as a best-effort writer for caching OCI image layers. A later change will haveUploadFromReaderuseUploadWriter.