Skip to content

feat: add GKE instance template metadata resolver to remove conflict label in karpenter. #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

IRONICBo
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Refer to the GCP Karpenter manual. We need to remove some predefined labels from the metadata.

Ref: https://docs.google.com/document/u/0/d/1FbWWIGn5soHHnRPRxnIxuninW4s64nFuYxjtOJPKXxg/mobilebasic

cc @jwcesign

Which issue(s) this PR fixes:

Fixes #16

Special notes for your reviewer:

Does this PR introduce a user-facing change?


@IRONICBo IRONICBo requested a review from jwcesign April 30, 2025 05:41
@IRONICBo IRONICBo self-assigned this Apr 30, 2025
Copy link
Contributor

gitautomator bot commented Apr 30, 2025

Thanks to your contribution, the maintainers will review it as soon as they can!

Copy link
Contributor

gitautomator bot commented Apr 30, 2025

The release note is either empty or incomplete, please consider: Added GKE instance template metadata resolver to remove conflict labels in Karpenter.

@gitautomator gitautomator bot added the enhancement New feature or request label Apr 30, 2025
@IRONICBo IRONICBo force-pushed the feat/support-metadata-parser branch from d2f1988 to 4189045 Compare April 30, 2025 06:05
Copy link
Contributor

@jwcesign jwcesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jwcesign jwcesign merged commit 8ddb303 into cloudpilot-ai:main Apr 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Karpenter GCP Provider Development
2 participants