Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helmet #534

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Helmet #534

wants to merge 3 commits into from

Conversation

NafiurSiddiqui
Copy link

Description

The issue caused by the #533 is react-helmet. Updating to react-helmet-async and fixing necessary changes fixed the issue and the app does not break.

  • Major changes inside the Layout Component
  • Wrapped the return from the layout component with HelmetProvider and removed Helmet.staticRender() since it is not required in helmet-async.
  • rest of the places I just imported Helmet from the react-helmet-async.

Issue Ticket Number

Fixes

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • [x ] I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresnding changes needed to the documentation

@vercel
Copy link

vercel bot commented Sep 2, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @colbyfayock on Vercel.

@colbyfayock first needs to authorize it.

@colbyfayock
Copy link
Owner

hey @NafiurSiddiqui can you check the diff here? You're checking in the entire .yarn/cache directory as well as deleting some files that are part of this project

@NafiurSiddiqui
Copy link
Author

hey @NafiurSiddiqui can you check the diff here? You're checking in the entire .yarn/cache directory as well as deleting some files that are part of this project

good grace! I just realized it was the repo that I was using for my personal project to play around with it. 😱 Extremely sorry about that. I am glad you have put up such a heavy guard. I will double check on the next commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants