Update trustee to support nebula VPN feature #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
It needs a config.yaml. This should be more configurable but will suffice for now. It needs a helper script for starting it. Signed-off-by: Chris Porter <[email protected]>
This is for local use or testing. It should point to a proper ghcr image in confidential-containers in the future. This may not be the best folder/location for this file. Signed-off-by: Chris Porter <[email protected]>
Signed-off-by: Chris Porter <[email protected]>
portersrc
changed the title
portersrc
commented
Jun 4, 2025
|
|
||
| images: | ||
| - name: lighthouse | ||
| newName: ghcr.io/portersrc/lighthouse |
There was a problem hiding this comment.
Need a hand from coco devs if we go this route
portersrc
commented
Jun 4, 2025
| - "bin/sh" | ||
| - "-c" | ||
| - "while (true); do sleep 10000; done" | ||
| image: ghcr.io/portersrc/lighthouse:latest |
There was a problem hiding this comment.
same here; would want ghcr.io/confidential-containers
cclaudio
reviewed
Jun 5, 2025
cclaudio
reviewed
Jun 5, 2025
| /usr/local/bin/kbs-client \ | ||
| --url http://${kbs_url}:${kbs_port} \ | ||
| get-resource \ | ||
| --path "plugin/nebula-ca/credential?name=nebula-lighthouse&ip=${lighthouse_vpn_ip}/${lighthouse_prefix_len}" \ |
There was a problem hiding this comment.
This may require plugin support in the kbs-client.
See the commit message of #539, section How to test the credential service
There was a problem hiding this comment.
You're right. Will address this in a separate PR.
portersrc
changed the title
Run the start-lighthouse.sh script when the container starts. Pass default values via CMD, but the user is expected to choose proper values here. Signed-off-by: Chris Porter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the nebula VPN feature, additional support is needed in trustee. The main changes here are:
staged-imagesbuild for KBS supports the nebula plugin by default. This will simplify end-to-end testing with kata-containers.