Skip to content

Fix relative paths, again #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 9, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix OS calc of current directory and fix windows headers inclusion
  • Loading branch information
Tal Hadad committed Apr 7, 2025
commit b90d5c517e90233f7bbd600d9ab0fd890e39b0ff
33 changes: 15 additions & 18 deletions simplecpp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,15 @@
#include <utility>
#include <vector>

#ifdef _WIN32
#include <direct.h>
#else
#include <unistd.h>
#endif

#ifdef SIMPLECPP_WINDOWS
#include <windows.h>
#undef ERROR
#else
#include <unistd.h>
#endif

#if __cplusplus >= 201103L
Expand Down Expand Up @@ -2686,24 +2690,17 @@ static bool isCpp17OrLater(const simplecpp::DUI &dui)


static std::string currentDirectoryOSCalc() {
#ifdef SIMPLECPP_WINDOWS
TCHAR NPath[MAX_PATH];
GetCurrentDirectory(MAX_PATH, NPath);
#ifdef _UNICODE
// convert the result from TCHAR* to char*
char NPathA[MAX_PATH];
::WideCharToMultiByte(CP_ACP, 0, NPath, lstrlen(NPath), NPathA, MAX_PATH, NULL, NULL);
return NPathA;
#else
// in this case, TCHAR* is just defined to be a char*
return NPath;
#endif
const std::size_t size = 4096;
char currentPath[size];

#ifndef _WIN32
if (getcwd(currentPath, size) != nullptr)
#else
const std::size_t size = 1024;
char the_path[size];
getcwd(the_path, size);
return the_path;
if (_getcwd(currentPath, size) != nullptr)
#endif
return std::string(currentPath);

return "";
}

static const std::string& currentDirectory() {
Expand Down
Loading