Skip to content

DuckDB read/write integration #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

DuckDB read/write integration #220

wants to merge 22 commits into from

Conversation

thomasmarwitz
Copy link
Contributor

@thomasmarwitz thomasmarwitz commented Apr 9, 2025 •
edited
Loading

Add initial support for duckdb (and pyarrow) s.t. no conversion to pandas.DataFrame is performed.

  • Docs
  • Changelog entry

xhochy
xhochy reviewed Apr 14, 2025
View reviewed changes
plateau/core/common_metadata.py
pandas_metadata = {
"columns": [],
"index_columns": [], # this function is only called if no pandas metadata is present, ergo we do not have any index columns
"pandas_version": pd.__version__,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hardcode the pandas version here. We are not using pandas at all but hardcode the logic that pandes uses at the time of writing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently, the "logic" uses at the time of writing is to just use the current version. So should I keep the pd.__version__?

plateau/io/duckdb/helper.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These functions all look familiar. Are these arrow rewrites of ones that exist as pandas versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align_categories is:

@thomasmarwitz
Copy link
Contributor Author

@xhochy do you think we can get this merged today?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy left review comments

@jtilly jtilly Awaiting requested review from jtilly jtilly will be requested when the pull request is marked ready for review jtilly is a code owner

@fjetter fjetter Awaiting requested review from fjetter fjetter will be requested when the pull request is marked ready for review fjetter is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasmarwitz @xhochy