feat: DH-19044: implement serial Filter API #6858
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
core
cpwright
reviewed
May 9, 2025
| * <ul> | ||
| * <li>Concurrency impact: The expression will never be invoked concurrently with itself.</li> | ||
| * <li>Intra-expression ordering impact: Rows are evaluated sequentially in row set order.</li> | ||
| * <li>Inter-expression ordering impact: Acts as an absolute reordering barrier, ensuring that no parts of a where |
There was a problem hiding this comment.
It is not clear to me that there should be any inter-expression ordering impact for serial. If you wanted the barrier, you could express it as a barrier; but if you have two expressions that are both serial there is no reason we could not at some point choose to evaluate them on separate threads.
| * @return a new instance of FilterSerial | ||
| */ | ||
| public static FilterSerial of(Filter filter) { | ||
| // Optionally, if the filter is already a FilterSerial, it could be returned directly. |
There was a problem hiding this comment.
We might as well do the optimization if we wrote a comment for it.
| /** | ||
| * A serial wrapper for a {@link WhereFilter} that enforces serial (non-parallel) execution. | ||
| */ | ||
| public class WhereFilterSerialImpl |
There was a problem hiding this comment.
An abstract base class shared between this and io.deephaven.engine.table.impl.select.WhereFilterInvertedImpl would make sense (really for anything that is a WhereFilter wrapping another WhereFilter which we might need more of later).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.