Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #34900 -- Confirmed Python 3.13 compatibility. #18657

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Refs #34900 -- Confirmed Python 3.13 compatibility. #18657

merged 2 commits into from
Oct 9, 2024

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Oct 8, 2024

@felixxm felixxm marked this pull request as draft October 8, 2024 06:45
@felixxm
Copy link
Member Author

felixxm commented Oct 8, 2024

OK, Let's wait for the final version in Ubuntu and GitHub actions.

@felixxm felixxm force-pushed the issue-34900 branch 2 times, most recently from 1f25252 to 6c92b38 Compare October 8, 2024 11:35
@felixxm
Copy link
Member Author

felixxm commented Oct 8, 2024

OK, we're making progress Jenkins nodes work fine 🎉

@felixxm felixxm marked this pull request as ready for review October 8, 2024 15:40
@felixxm
Copy link
Member Author

felixxm commented Oct 8, 2024

It's ready 🎉

pauloxnet
pauloxnet approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixxm felixxm added the selenium Apply to have Selenium tests run on a PR label Oct 8, 2024
adamchainz
adamchainz approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@adamchainz adamchainz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

sarahboyce
sarahboyce approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sarahboyce sarahboyce merged commit 2e3bc59 into django:main Oct 9, 2024
46 checks passed
@felixxm felixxm deleted the issue-34900 branch October 9, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahboyce sarahboyce sarahboyce approved these changes

@adamchainz adamchainz adamchainz approved these changes

@pauloxnet pauloxnet pauloxnet approved these changes

Assignees
No one assigned
Labels
selenium Apply to have Selenium tests run on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixxm @pauloxnet @adamchainz @sarahboyce