Changes header navigation to a <nav> element, style by ID #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🐼 Thank you for the PR, could you please enter a description of what it is solving, etc. |
knyghty
approved these changes
Jun 2, 2023
sabderemane
requested changes
Jul 13, 2023
Whitespace conflict. django:main moved from tabs to spaces.
sabderemane
reviewed
Sep 27, 2023
There was a problem hiding this comment.
Thank you for the updates @devanubis, I'm afraid there are others changes needed: role="navigation" is used in 3 others pages : search_result.html, feeditem_list.html, blog_pagination.html so changing the style in _style.scss will impact those 3 elements.
Plus, did you check if it's rendering correctly on mobile ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a
<nav>element for the top mavigation bar, instead ofrole="navitation".These are semantically equivalent, but its better to style by class or ID than by role/element type, as other content on the page may be marked up as
<nav>in future (e.g. the docs side bar).