DVDThread: State save read requests without result data. #13612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes two TODOs in DVDThread.
Rather than waiting for read requests to complete, all requests are now state saved without their results.
I added some additional features to
WorkQueueThread
to accomplish this.A separate
WaitableSPSCQueue
command queue eliminates the "run_thread" and "skip_work" flags and allows additional tasks like gathering all the items while the thread is running.I also changed result data from
std::vector
toCommon::UniqueBuffer
to avoid the zero-initialization.In my testing, there are usually zero pending requests, and this isn't a huge benefit, but here it is anyway.
Maybe someone knows a particular game that's DVD-read heavy?