-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Hashtable/ArrayList in AccessKeyManager and remove locks #10000
Open
h3xds1nz
wants to merge
16
commits into
dotnet:main
Choose a base branch
from
h3xds1nz:accesskey-manager-collections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
October 25, 2024 17:34
dotnet-policy-service
bot
added
PR
metadata: Label to tag PRs, to facilitate with triage
Community Contribution
A label for all community Contributions
labels
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community Contribution
A label for all community Contributions
PR
metadata: Label to tag PRs, to facilitate with triage
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10000, would you look at that?
Description
This basically turned into overhaul of
AccessKeyManager
because unless I've missed a class on threading and read the code incorrectly, there's just a lot of unnecessary overhead within the entire class that deserves to be removed._keyToElements
since it is an instance member and all instances are inherently one per thread (AccessKeyManager
has a privatector
that is only called via privateCurrent
property where the instance is stored in[ThreadStatic] s_accessKeyManager
variable. So there should be no way how a different thread can ever gain access to an instance of the dictionary with current code.static
as they either do not modify state or request the one-per-thread instance fromCurrent
and can gain access to the only instance member via the property.AccessKeyInformation
is now areadonly struct
as there's no reason for it to be mutable.ArrayList
, we will swap toList<WeakReference<IInputElement>>
.Hashtable
, we will swap toDictionary<string, List<WeakReference<IInputElement>>>
.WeakReference
, we will use the genericWeakReference<IInputElement>
.CriticalGetActiveSource
was removed as it duplicatesGetActiveSource
.AccessKeyEventArgs
/AccessKeyPressedEventArgs
were madereadonly
.Customer Impact
Increased performance, faster startup, decreased allocations.
Regression
No.
Testing
Local build, testing with access keys.
Risk
Low-to-medium, while the changes are mostly replacements, there are different uses of indexers (
Hashtable
vsDictionary
) and work with genericWeakReference
is different, so reviewers shall pay attention I did do anything that shall change behaviour in that regard though from my testing it seemed fine.Microsoft Reviewers: Open in CodeFlow