Remove GenericsInstances class from WindowsBase as it no longer needed #9990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
GenericsInstancesclass that was solely used forngenpurposes inNetFXto trigger generation for those generic types that were otherwise only defined on interfaces inWindowsBase(see comment).I have done a test with CrossGen2 (R2R) and this wasn't being jitted. So imho it is safe to say it has outlived its purpose.
Using the output of
DOTNET_JitDisasmSummary=1; while without publishing as R2R all those things were.Customer Impact
Decreased assemblies size, cleaner codebase for developers.
Regression
No.
Testing
Local build, app run (more in description).
Risk
Don't think there's any.
Microsoft Reviewers: Open in CodeFlow