-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds filtering sandboxes by state in the SDKs #564
Open
mishushakov
wants to merge
19
commits into
beta
Choose a base branch
from
filtering-sandboxes-state
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6504900
Adds filtering sandboxes by state in the SDKs
mishushakov 039b7a3
regenerated api spec
mishushakov 33f2c07
fixes types/unset
mishushakov 60a75a8
pass sandbox.list test for snapshots
mishushakov 1f95e44
updated openapi spec and tests for list
mishushakov 8c096b1
added docs on Sandbox.list
mishushakov a90ebc4
added changes from #565
mishushakov 76d8a94
added a changeset
mishushakov 5e1c6ab
updated the doc
mishushakov d688463
use literals for python enums
mishushakov 6bc1c1b
added docs for removing paused sandboxes
mishushakov 8b48134
expanded how to kill arbitrary sandboxes
mishushakov 5f0c179
Fix generator version
jakubno fe1ffa7
updated openapi spec to match the latest
mishushakov 5803a4f
updated spec, made possible to filter state by array
mishushakov 1898417
removed unnecessary global serializer
mishushakov 20bb345
reversed startedAt nullability
mishushakov a8ec896
filter sandboxes by state in the cli
mishushakov f58ad17
added way to filter sandboxes by metadata in the cli
mishushakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@e2b/python-sdk': minor | ||
'e2b': minor | ||
'@e2b/cli': minor | ||
--- | ||
|
||
Adds filtering sandboxes by state in the SDKs and display of the state in the CLI |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 7 additions & 7 deletions
14
packages/python-sdk/e2b/api/client/api/sandboxes/delete_sandboxes_sandbox_id.py
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mishushakov will deleting paused sandboxes be included in a separate PR? I'm asking because the new docs addition doesn't mention anything about deleting paused sandboxes.
Other than that, this looks good to me on the docs level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will be a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I have decided to add it here as well to avoid merge conflicts