Add paused sandboxes to the list of running sandboxes #264
Conversation
| // Report analytics | ||
| a.posthog.IdentifyAnalyticsTeam(team.ID.String(), team.Name) | ||
| properties := a.posthog.GetPackageToPosthogProperties(&c.Request.Header) | ||
| a.posthog.CreateAnalyticsTeamEvent(team.ID.String(), "listed running instances", properties) |
There was a problem hiding this comment.
the name of the event isn't true anymore
There was a problem hiding this comment.
wdym? same as was before
infra/packages/api/internal/handlers/sandboxes_list.go
Lines 92 to 94 in 20aff1d
There was a problem hiding this comment.
Sorry, am still not understanding what is required from me, can you suggest the change?
| @@ -24,26 +24,57 @@ func (a *APIStore) GetSandboxesSandboxID(c *gin.Context, id string) { | |||
|
|
|||
There was a problem hiding this comment.
Can you change the event above? 🙏🏻
There was a problem hiding this comment.
I am not seeing the line you're talking about?
|
I think we should make StartedAt non-nullable to avoid breaking existing types and instead set 1/1/1970 for unknown snapshot date in the db? |
|
I have undone the nullability |
|
Here's the script for filling in sandbox_started_at from logs UPDATE public.snapshots s
SET sandbox_started_at = bl.started_at
FROM billing.sandbox_logs bl
WHERE s.sandbox_id = bl.sandbox_id; |
Includes changes from #263